[PATCH] [PATCH v4] [PowerPC] Add Hardware Transaction Memory builtins support

Bill Schmidt wschmidt at linux.vnet.ibm.com
Thu Mar 19 13:14:14 PDT 2015

LGTM, with one minor nit that you can "take under advisement."  Hal, any concerns?

Comment at: test/CodeGen/PowerPC/htm.ll:80
@@ +79,3 @@
+; CHECK-LABEL: @test5
+; CHECK: mtspr 130, [[REG1:[0-9]+]]
+; CHECK: mtspr 131, [[REG2:[0-9]+]]
>From here to the end, all of these could be {{[0-9]+}} since the named value is not reused.  Not a big deal, but a good habit to be in.  Changing this is optional, patch looks fine otherwise.



More information about the llvm-commits mailing list