[PATCH] Optimize isValueEqualInPotentialCycles

Daniel Berlin dberlin at dberlin.org
Wed Mar 18 22:26:19 PDT 2015


Hi nlewycky, hfinkel,

On larger test cases, we actually spend some time going to grab pass info and such, to be able to do the for loop, even if there is nothing in the visited set.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8433

Files:
  lib/Analysis/BasicAliasAnalysis.cpp

Index: lib/Analysis/BasicAliasAnalysis.cpp
===================================================================
--- lib/Analysis/BasicAliasAnalysis.cpp
+++ lib/Analysis/BasicAliasAnalysis.cpp
@@ -1526,6 +1526,9 @@
   if (!Inst)
     return true;
 
+  if (VisitedPhiBBs.empty())
+    return true;
+
   if (VisitedPhiBBs.size() > MaxNumPhiBBsValueReachabilityCheck)
     return false;

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8433.22239.patch
Type: text/x-patch
Size: 384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150319/57b3492f/attachment.bin>


More information about the llvm-commits mailing list