[PATCH] [InstCombine] Don't fold a GEP into itself through a PHI node

Nick Lewycky nicholas at mxc.ca
Wed Mar 18 20:30:41 PDT 2015


Daniel Jasper wrote:
> Ping?

     if (!Op2 || Op1->getNumOperands() != Op2->getNumOperands())
       return nullptr;
‚Äč
+   // As for Op1 above, don't try to fold a GEP into itself.
+   if (Op2 == &GEP)
+     return nullptr;

Consider folding that into the check above.

LGTM

> http://reviews.llvm.org/D8245
>
> EMAIL PREFERENCES
>    http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>





More information about the llvm-commits mailing list