[PATCH] [Hexagon] Handle ENDLOOP0 in InsertBranch and RemoveBranch

Krzysztof Parzyszek kparzysz at codeaurora.org
Wed Mar 18 09:10:12 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/Hexagon/HexagonInstrInfo.cpp:326-329
@@ +325,6 @@
+  switch (Opc1) {
+    case Hexagon::J2_jump:
+    case Hexagon::J2_jumpt:
+    case Hexagon::J2_jumpf:
+    case Hexagon::ENDLOOP0:
+      I->eraseFromParent();
----------------
djasper wrote:
> LLVM style generally does not indent the case labels.
> 
> Do you think that these switches are really more readable? They seem a lot longer...
Lack of phabricator skill.  I replied in the top-level comments instead of here.

http://reviews.llvm.org/D8418

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list