[PATCH] Add RelocVisitor support for MachO

Frédéric Riss friss at apple.com
Tue Mar 17 14:08:56 PDT 2015

> On Mar 17, 2015, at 2:00 PM, Keno Fischer <kfischer at college.harvard.edu> wrote:
> Bump. Could somebody look at the DWARFDebugLine bug fix at least? It doesn't have to do much with MachO (except that it's exposed by running it on the MachO test case). That's the major functional point that needs review here.

I’m sorry, I’m out of work for a few weeks, and I won’t be able to review it correctly. However a couple of things stood out when I looked at it last week:
 - you definitely should separate the debug line fix from the RelocVisitor implementation.
 - MachO object files contain another relocation type (X86_64_RELOC_SUBTRACTOR if memory serves), and I don’t know if it really fits in the RelocVisitor model (as it needs access to the following reloc to make sense). Why is RELOC_UNSIGNED sufficient for your usecase?


>  rL LLVM
> http://reviews.llvm.org/D8148
>  http://reviews.llvm.org/settings/panel/emailpreferences/

More information about the llvm-commits mailing list