[PATCH] Fix race condition in Defined Atom ordinal computation.

Rui Ueyama ruiu at google.com
Mon Mar 16 12:16:10 PDT 2015


Thank you for doing this. I wonder if we use _ordinal assigned here in the constructor. We usually assign ordinals explicitly in the reader, so I hope ordinals assigned here are overwritten in all use cases. If you change this to UINT_MAX or something and make ordinal() to abort if it's still UINT_MAX, does the linker fail with the assertion?

This change is good to mitigate the situation, so I'm OK to commit as a quick fix, but the actual fix should be assigning ordinals explicitly.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8336

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list