[PATCH] Add support of multiple test compilers and architecture for LLDB cmake builder

Siva Chandra sivachandra at google.com
Mon Mar 16 11:31:18 PDT 2015

Comment at: buildbot/osuosl/master/config/builders.py:722
@@ -722,1 +721,3 @@
+                    test_arch=['x86_64', 'i386'],
+                    test_compilers=['clang', 'totclang', 'gcc4.8.2'],
Can we have two archs on the same build slave??

Comment at: zorg/buildbot/builders/LLDBBuilder.py:246
@@ +245,3 @@
+    if test_arch is None:
+        test_arch={}
+    if test_compilers is None:
This should be initialized with the default system architecture.

Comment at: zorg/buildbot/builders/LLDBBuilder.py:248
@@ -244,1 +247,3 @@
+    if test_compilers is None:
+        test_compilers={}
You should probably check for presence of clang, gcc or cc in that order and default a test compiler to that.

Comment at: zorg/buildbot/builders/LLDBBuilder.py:303
@@ +302,3 @@
+        for arch in test_arch:
+            f.addStep(LitTestCommand(name="test lldb (%s-%s)" % (compiler, arch),
+                                     command=['../%s/tools/lldb/test/dosep.py' % llvm_srcdir,
You should probably have a step which cleans up the source tree and the build tree after each test step. Side effects from a previous test run could potentially affect a consequent test run.



More information about the llvm-commits mailing list