[PATCH] Add support for .ifnes pseudo-op.

Chad Rosier mcrosier at codeaurora.org
Mon Mar 16 08:08:36 PDT 2015


Looks good in general with a few comments.

Also, for future reference, please include full context in your patches.  See the following link on how to get a full context in Phabricator:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Chad


REPOSITORY
  rL LLVM

================
Comment at: lib/MC/MCParser/AsmParser.cpp:438
@@ -437,2 +437,3 @@
   bool parseDirectiveIfc(SMLoc DirectiveLoc, bool ExpectEqual);
   // ".ifeqs"
+  bool parseDirectiveIfeqs(SMLoc DirectiveLoc, bool ExpectEqual);
----------------
Update comment to reflect that this parse .ifeqs and .ifnes.

================
Comment at: lib/MC/MCParser/AsmParser.cpp:3950
@@ -3947,3 +3949,3 @@
   if (Lexer.isNot(AsmToken::String)) {
     TokError("expected string parameter for '.ifeqs' directive");
     eatToEndOfStatement();
----------------
This logic is specific to .ifeqs.

You'll need to conditionalize more of the code, if you'd like to reuse the function.

http://reviews.llvm.org/D8356

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list