[llvm] r232349 - [objc-arc] Rename ConnectTDBUTraversals => PairUpRetainsReleases.

Michael Gottesman mgottesman at apple.com
Mon Mar 16 00:02:30 PDT 2015


Author: mgottesman
Date: Mon Mar 16 02:02:30 2015
New Revision: 232349

URL: http://llvm.org/viewvc/llvm-project?rev=232349&view=rev
Log:
[objc-arc] Rename ConnectTDBUTraversals => PairUpRetainsReleases.

This is a name that is more descriptive of what the method really does. NFC.

Modified:
    llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp

Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp?rev=232349&r1=232348&r2=232349&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp (original)
+++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp Mon Mar 16 02:02:30 2015
@@ -459,15 +459,16 @@ namespace {
                    DenseMap<Value *, RRInfo> &Releases,
                    SmallVectorImpl<Instruction *> &DeadInsts, Module *M);
 
-    bool ConnectTDBUTraversals(DenseMap<const BasicBlock *, BBState> &BBStates,
-                               BlotMapVector<Value *, RRInfo> &Retains,
-                               DenseMap<Value *, RRInfo> &Releases, Module *M,
-                               SmallVectorImpl<Instruction *> &NewRetains,
-                               SmallVectorImpl<Instruction *> &NewReleases,
-                               SmallVectorImpl<Instruction *> &DeadInsts,
-                               RRInfo &RetainsToMove, RRInfo &ReleasesToMove,
-                               Value *Arg, bool KnownSafe,
-                               bool &AnyPairsCompletelyEliminated);
+    bool
+    PairUpRetainsAndReleases(DenseMap<const BasicBlock *, BBState> &BBStates,
+                             BlotMapVector<Value *, RRInfo> &Retains,
+                             DenseMap<Value *, RRInfo> &Releases, Module *M,
+                             SmallVectorImpl<Instruction *> &NewRetains,
+                             SmallVectorImpl<Instruction *> &NewReleases,
+                             SmallVectorImpl<Instruction *> &DeadInsts,
+                             RRInfo &RetainsToMove, RRInfo &ReleasesToMove,
+                             Value *Arg, bool KnownSafe,
+                             bool &AnyPairsCompletelyEliminated);
 
     bool PerformCodePlacement(DenseMap<const BasicBlock *, BBState> &BBStates,
                               BlotMapVector<Value *, RRInfo> &Retains,
@@ -1453,7 +1454,7 @@ void ObjCARCOpt::MoveCalls(Value *Arg, R
 
 }
 
-bool ObjCARCOpt::ConnectTDBUTraversals(
+bool ObjCARCOpt::PairUpRetainsAndReleases(
     DenseMap<const BasicBlock *, BBState> &BBStates,
     BlotMapVector<Value *, RRInfo> &Retains,
     DenseMap<Value *, RRInfo> &Releases, Module *M,
@@ -1705,11 +1706,10 @@ bool ObjCARCOpt::PerformCodePlacement(
     // Connect the dots between the top-down-collected RetainsToMove and
     // bottom-up-collected ReleasesToMove to form sets of related calls.
     NewRetains.push_back(Retain);
-    bool PerformMoveCalls =
-      ConnectTDBUTraversals(BBStates, Retains, Releases, M, NewRetains,
-                            NewReleases, DeadInsts, RetainsToMove,
-                            ReleasesToMove, Arg, KnownSafe,
-                            AnyPairsCompletelyEliminated);
+    bool PerformMoveCalls = PairUpRetainsAndReleases(
+        BBStates, Retains, Releases, M, NewRetains, NewReleases, DeadInsts,
+        RetainsToMove, ReleasesToMove, Arg, KnownSafe,
+        AnyPairsCompletelyEliminated);
 
     if (PerformMoveCalls) {
       // Ok, everything checks out and we're all set. Let's move/delete some





More information about the llvm-commits mailing list