[PATCH] [LLVM] Add support for armv6k subtarget

Tim Northover t.p.northover at gmail.com
Sun Mar 15 22:11:10 PDT 2015


================
Comment at: test/MC/ARM/arm11-hint-instr.s:48-49
@@ +47,4 @@
+
+ at ------------------------------------------------------------------------------
+@ v6T2 uses ARM encoding
+ at ------------------------------------------------------------------------------
----------------
I think this is a bit misleading. A v6T2 CPU ought to assemble the instructions in both ARM and Thumb mode. It's your triple that forces it to use in ARM mode, not an intrinsic property of the processor.

I'd suggest merging CHECK-V6K and CHECK-V6T2 into CHECK-ARM. V6M is always special (possibly with a capital 'S'), it's fine as is.

http://reviews.llvm.org/D8126

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list