[PATCH] Add support for armv6k subtarget

Tim Northover t.p.northover at gmail.com
Sun Mar 15 10:46:52 PDT 2015


I think it looks fine too, as long as one test is made a bit stricter.

Tim.


================
Comment at: test/MC/ARM/arm11-hint-instr.s:3-5
@@ +2,5 @@
+@ RUN:     | FileCheck --check-prefix=CHECK-ERRORS %s
+@ RUN: llvm-mc -triple=armv6k -mcpu=mpcore -o /dev/null < %s
+@ RUN: llvm-mc -triple=armv6k -mcpu=arm1176jzf-s -o /dev/null < %s
+@ RUN: llvm-mc -triple=armv6t2 -mcpu=arm1156t2f-s -o /dev/null < %s
+
----------------
Probably best to put actual FileCheck tests in here (with the ARM encoding). It's very easy to accidentally make a Thumb encoding available on ARM (or vice-versa) with a slightly dodgy InstAlias.

I don't think you have, but for future changes...

http://reviews.llvm.org/D8126

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list