[PATCH] Fix race condition in Defined Atom ordinal computation.

Jean-Daniel Dupas mailing at xenonium.com
Fri Mar 13 23:44:12 PDT 2015


But now that I think about it, there is just something wrong in the first place with that ordinal. It it either meaning full inside a single input file, and we shouldn’t use a static or don’t care about race condition, or it is meaningful across files and I don’t see how it can be as loading file in parallel make it indeterministic anyway.

> Le 14 mars 2015 à 07:22, Jean-Daniel Dupas <mailing at xenonium.com> a écrit :
> 
> That’s true for input file, but having the same ordinal for 2 atoms raise an assert in MachO Layout Pass which is run on the generated file (that contains atom from many files)
> 
> 
>> Le 14 mars 2015 à 06:22, Shankar Kalpathi Easwaran <shankarke at gmail.com> a écrit :
>> 
>> am confused, Atoms live within a File and when the ordinals would be relative inside the file. So for your case do more than one file share the same SimpleDefinedAtom ? Am I missing some information ?
>> 
>> 
>> REPOSITORY
>> rL LLVM
>> 
>> http://reviews.llvm.org/D8336
>> 
>> EMAIL PREFERENCES
>> http://reviews.llvm.org/settings/panel/emailpreferences/
>> 
>> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list