[PATCH] [mips] [IAS] Outline NOP creation. NFC.

Daniel Sanders daniel.sanders at imgtec.com
Fri Mar 13 09:14:35 PDT 2015


LGTM


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1981
@@ +1980,3 @@
+  if (AssemblerOptions.back()->isReorder())
+    createNop(true /* hasShortDelaySlot */, IDLoc, Instructions);
+
----------------
Nit: The comment isn't really necessary. The argument isn't optional and isn't easily confused with the neighbouring arguments.

http://reviews.llvm.org/D8320

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list