[PATCH] [LoopInterchange] Add support to interchange loops with reductions.

[Renato Golin]

Hi Karthik,

Wouldn't this be better to be integrated into the vectorizer? Or at least, not duplicated code from the vectorizer?

Also, you have at least two other bold moves:

1. Move a lot of internal methods to static. This could be ok, but needs some further explanation why it is so.
2. Move the interchange pass down the pipeline. Again, it could be the right thing to do, but also needs some context.

Finally, how did you test and benchmark your changes? "It makes my code 3x faster" is not enough to include such a big change. The steps you need to complete to get such a change in  are in order:

1. Run the "make check-all" tests and make sure they're green
2. Run the test-suite and make sure it passes *and* doesn't regress performance
3. Provide more information about the benchmarks that you tested it, relative improvements, regressions, etc.

cheers,
--renato


http://reviews.llvm.org/D8314

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/