[PATCH] [llvm-readobj] add support for macho universal binary

Chilledheart rwindz0 at gmail.com
Thu Mar 12 09:13:25 PDT 2015


I am not sure if explicit initialization of `MachOUniversalBinary::Objects` is good enough. Maybe we need to change the `MachOUniversalBinary::object_iterator` to `typedef ObjectForArch* object_iterator` and related code as well to use `MachOUniversalBinary::Objects` directly?


================
Comment at: tools/llvm-readobj/llvm-readobj.cpp:331
@@ +330,3 @@
+    if (std::error_code EC = ObjOrErr.getError()) {
+      // Ignore non-object files.
+      if (EC != object_error::invalid_file_type)
----------------
rafael wrote:
> Why? Do we really get universal binaries with non Object Members?
Sorry, I'll remove the dead code in the next patch.

http://reviews.llvm.org/D8161

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list