[PATCH] Fix makeLibCall arguments for SoftenFloatRes_FRINT function

Petar Jovanovic petar.jovanovic at imgtec.com
Tue Mar 10 18:06:36 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:494
@@ -493,2 +493,3 @@
   SDValue Op = GetSoftenedFloat(N->getOperand(0));
+  bool shouldSignExtend = TLI.shouldSignExtendFloat32InAbiCall();
   return TLI.makeLibCall(DAG, GetFPLibCall(N->getValueType(0),
----------------
hfinkel wrote:
> Why did you name the callback shouldSignExtendFloat32InAbiCall when the use is not specific to f32? I recommend having the callback take the type, and taking Float32 out of the name.
The need for this change comes from MIPS64 decision to keep 32-bit values in registers by sign-extending them to 64 bits.
Maybe the function name should reflect that?

http://reviews.llvm.org/D7791

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list