[PATCH] New "strict_string_checks" run-time flag

Kostya Serebryany kcc at google.com
Tue Mar 10 11:46:18 PDT 2015


I like the patch. At this point I'd ask Dmitry to review the tsan part and comment on internal_str* vs REAL(str*) in tsan.

In parallel, given that the patch is potentially very intrusive, I'd ask you to test it with asan bootstrap:

1. build clang as usual
2. build another clang using clang from #1 with cmake flag -DLLVM_USE_SANITIZER=Address and run "ninja check-llvm check-clang"
3. Repeat #2 with ASAN_OPTIONS=strict_string_checks=true

If new errors appear in LLVM, you don't have to fix them, but at least check that they are not false positives.


================
Comment at: test/asan/TestCases/atol_strict.c:13
@@ +12,3 @@
+
+
+
----------------
remove extra vertical space, leave just one line (here and below)

http://reviews.llvm.org/D7123

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list