[PATCH] Add support for part-word atomics for PPC

hfinkel at anl.gov hfinkel at anl.gov
Mon Mar 9 16:33:47 PDT 2015


LGTM (aside from some minor formatting nits).


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/PowerPC/PPC.td:122
@@ +121,3 @@
+def FeaturePartwordAtomic : SubtargetFeature<"partword-atomics",
+                                               "HasPartwordAtomics", "true",
+                                               "Enable l[bh]arx and st[bh]cx.">;
----------------
Indentation is off here.

================
Comment at: lib/Target/PowerPC/PPCInstr64Bit.td:240
@@ -238,2 +239,3 @@
 def LDARX : XForm_1<31,  84, (outs g8rc:$rD), (ins memrr:$ptr),
                    "ldarx $rD, $ptr", IIC_LdStLDARX,
+                   []>;
----------------
Indentation is off here and below (the " should be under the 3).

================
Comment at: lib/Target/PowerPC/PPCInstrInfo.td:1447
@@ +1446,3 @@
+def LBARX : XForm_1<31,  52, (outs gprc:$rD), (ins memrr:$src),
+                   "lbarx $rD, $src", IIC_LdStLWARX,
+                   []>,
----------------
Indentation looks off-by-one here too.

http://reviews.llvm.org/D8090

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list