[PATCH] Add 'vs' parameter to Clang CMake builder to indicate Windows

Galina Kistanova gkistanova at gmail.com
Mon Mar 9 15:38:37 PDT 2015


Doesn't cmake take the CC and CXX from envs?
Maybe setting env would be better than adding another dependency for a long
run?

On Mon, Mar 9, 2015 at 3:16 PM, Reid Kleckner <rnk at google.com> wrote:

> On Mon, Mar 9, 2015 at 3:06 PM, Galina <gkistanova at gmail.com> wrote:
>
>> LGTM
>> Though, I have a question. I'm not very familiar with the Windows you are
>> running, but it seems 'env' is not a standard Windows command, is it? If
>> so, could you add a note for the extra dependency, please?
>
>
> Sure. Any slave will need to have it to run the tests. It happens to
> already be on PATH for my slave, but that might not be true for others.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150309/d1f28d3d/attachment.html>


More information about the llvm-commits mailing list