[polly] r231593 - Add end user report message for unprofitable regions [NFC]

Johannes Doerfert doerfert at cs.uni-saarland.de
Sun Mar 8 09:15:44 PDT 2015

On 03/08, Tobias Grosser wrote:
> On 08.03.2015 17:00, Johannes Doerfert wrote:
> >On 03/08, Tobias Grosser wrote:
> >>On 08.03.2015 16:11, Johannes Doerfert wrote:
> >>>  ; CHECK: remark: /tmp/test.c:2:3: The following errors keep this region from being a Scop.
> >>>+; CHECK: remark: /tmp/test.c:2:3: The regions does not seem to be amendable to profitable polyhedral optimization
> >>
> >>'The region' without 's', also
> >also what?
> I was thinking of a possibly shorten this to something like:
> 'No profitable polyhedral optimization found'
Sure. Go ahead.

> but was not sure if this actually might improve readability. What do you
> think?
I just want a "real" message because our default user message:

   virtual std::string getEndUserMessage() const {
     return "Unspecified error.";

is kinda useless and for this and some other cases no message is given after:
  remark: LOCATION: The following errors keep this region from being a Scop.

I have student groups working on Polly and I think a lot of question could
be avoided if we allow the user to get more high-level information about
the detection as well as other steps.


Johannes Doerfert
Researcher / PhD Student

Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.31

Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065  : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150308/92559288/attachment.sig>

More information about the llvm-commits mailing list