[PATCH] Remove all MMOs from memory operations when tail merging.

Ana Pazos apazos at codeaurora.org
Fri Mar 6 16:58:46 PST 2015


Hi Chad, thanks for the suggestions. I incorporated what I agreed with.

The patch you commented on had only the operator change. But the previous patch to that one had the other changes you listed (refer o previous patch commit message):

(1) I was potentially removing MMOs from all LD/ST instructions inside the common tail.
 I should have been more conservative and remove MMOs from the corresponding LD/ST instructions between a block and the common tail.
 (2) The "CommonTailLen" includes matching instructions between a block and the common tail, but it can also include additional debug instructions.
 I have to discount these debug instructions.

Thanks!


http://reviews.llvm.org/D7769

Files:
  include/llvm/CodeGen/MachineInstr.h
  include/llvm/CodeGen/MachineMemOperand.h
  lib/CodeGen/BranchFolding.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7769.21408.patch
Type: text/x-patch
Size: 4964 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150307/c1bf43d5/attachment.bin>


More information about the llvm-commits mailing list