[llvm] r231214 - Revert "[ADT] fail-fast iterators for DenseMap"

Chandler Carruth chandlerc at google.com
Fri Mar 6 12:47:21 PST 2015


On Fri, Mar 6, 2015 at 12:39 PM, Sanjoy Das <sanjoy at playingwithpointers.com>
wrote:

> Another way of approaching the problem: keep the two words in
> DenseMapIterators even in non-asserts mode, and have the asserts mode
> only turn on the assertions.  I'd speculate that not many places
> within LLVM/Clang/LLDB keep around iterators long enough for this to
> impact RAM usage from the size bloat within the iterators.
>

It has more impact than that though. It also means we need 3x the
registers, 3x the function arguments, etc etc. I think this is a pretty
high cost to pay.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150306/783b0687/attachment.html>


More information about the llvm-commits mailing list