[llvm] r231497 - [AsmPrinter][TLOF] XFAIL AArch64 test to appease buildbots

Hans Wennborg hans at chromium.org
Fri Mar 6 11:35:10 PST 2015


XFAIL means the test is expected to fail. If it sometimes passes due
to non-deterministic emission order, it breaks the test suite.

Maybe just delete the test since it's not actually testing anything at
the moment?

On Fri, Mar 6, 2015 at 10:38 AM, Bruno Cardoso Lopes
<bruno.cardoso at gmail.com> wrote:
> Author: bruno
> Date: Fri Mar  6 12:38:42 2015
> New Revision: 231497
>
> URL: http://llvm.org/viewvc/llvm-project?rev=231497&view=rev
> Log:
> [AsmPrinter][TLOF] XFAIL AArch64 test to appease buildbots
>
> The checking for extgotequiv and localgotequiv rely on the emission
> order, which is not guaranteed because we use DenseMap to hold the GOT
> equivalents. XFAIL this now until I get time to use MapVector and test
> out the solution. In the meantime, appease buildbots.
>
> Modified:
>     llvm/trunk/test/MC/MachO/AArch64/cstexpr-gotpcrel.ll
>
> Modified: llvm/trunk/test/MC/MachO/AArch64/cstexpr-gotpcrel.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/MachO/AArch64/cstexpr-gotpcrel.ll?rev=231497&r1=231496&r2=231497&view=diff
> ==============================================================================
> --- llvm/trunk/test/MC/MachO/AArch64/cstexpr-gotpcrel.ll (original)
> +++ llvm/trunk/test/MC/MachO/AArch64/cstexpr-gotpcrel.ll Fri Mar  6 12:38:42 2015
> @@ -2,6 +2,11 @@
>  ; RUN:  FileCheck %s -check-prefix=ARM < %t
>  ; RUN:  FileCheck %s -check-prefix=ARM-GOT-EQUIV < %t
>
> +; FIXME: the checking for extgotequiv and localgotequiv rely on the emission
> +; order, which is not guaranteed because we use DenseMap to hold the GOT
> +; equivalents.
> +; XFAIL: *
> +
>  ; GOT equivalent globals references can be replaced by the GOT entry of the
>  ; final symbol instead.



More information about the llvm-commits mailing list