[PATCH] [compiler-rt] Symbolizer refactoring: Make WinSymbolizer use SymbolizerTool interface

[Kuba Brecka]

Updating patch.

> SymbolizerTool comments assume POSIX. Can you please update the comments there to remove this assumption?


I've added a general comment about SymbolizerTool, but currently `POSIXSymbolizer` is really the only one that implements the chain of symbolizers.  After I merge `POSIXSymbolizer` and `WinSymbolizer` into just `Symbolizer`, I will update the comment.

> What's the problem with FindModuleNameAndOffsetForAddress initializing dbghelp?


There's no problem, if you're fine with moving the methods and field outside of the WinSymbolizer class.  I was just thinking that we might use the same implementation of `FindModuleNameAndOffsetForAddress` that we have in `POSIXSymbolizer`, which would simplify sanitizer_symbolizer_win.cc even more (maybe I'll try to do it as a separate patch).


http://reviews.llvm.org/D8089

Files:
  lib/sanitizer_common/sanitizer_symbolizer_internal.h
  lib/sanitizer_common/sanitizer_symbolizer_win.cc
  lib/sanitizer_common/sanitizer_symbolizer_win.h

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8089.21342.patch
Type: text/x-patch
Size: 13160 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150306/3dfbcfbb/attachment.bin>