[PATCH] [compiler-rt] Symbolizer refactoring: Make WinSymbolizer use SymbolizerTool interface
kuba.brecka at gmail.com
Fri Mar 6 05:24:03 PST 2015
> SymbolizerTool comments assume POSIX. Can you please update the comments there to remove this assumption?
I've added a general comment about SymbolizerTool, but currently `POSIXSymbolizer` is really the only one that implements the chain of symbolizers. After I merge `POSIXSymbolizer` and `WinSymbolizer` into just `Symbolizer`, I will update the comment.
> What's the problem with FindModuleNameAndOffsetForAddress initializing dbghelp?
There's no problem, if you're fine with moving the methods and field outside of the WinSymbolizer class. I was just thinking that we might use the same implementation of `FindModuleNameAndOffsetForAddress` that we have in `POSIXSymbolizer`, which would simplify sanitizer_symbolizer_win.cc even more (maybe I'll try to do it as a separate patch).
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 13160 bytes
Desc: not available
More information about the llvm-commits