[compiler-rt] r231457 - asan: fix comment formatting

Dmitry Vyukov dvyukov at google.com
Fri Mar 6 00:43:44 PST 2015


Author: dvyukov
Date: Fri Mar  6 02:43:44 2015
New Revision: 231457

URL: http://llvm.org/viewvc/llvm-project?rev=231457&view=rev
Log:
asan: fix comment formatting

As per comments in http://reviews.llvm.org/D8032


Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld.h
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld.h
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld.h?rev=231457&r1=231456&r2=231457&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld.h (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld.h Fri Mar  6 02:43:44 2015
@@ -60,7 +60,7 @@ typedef void (*StopTheWorldCallback)(
 // Suspend all threads in the current process and run the callback on the list
 // of suspended threads. This function will resume the threads before returning.
 // The callback should not call any libc functions. The callback must not call
-// exit nor _exit and instead return to the caller.
+// exit() nor _exit() and instead return to the caller.
 // This function should NOT be called from multiple threads simultaneously.
 void StopTheWorld(StopTheWorldCallback callback, void *argument);
 

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc?rev=231457&r1=231456&r2=231457&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc Fri Mar  6 02:43:44 2015
@@ -421,9 +421,9 @@ void StopTheWorld(StopTheWorldCallback c
     // Allow the tracer thread to start.
     tracer_thread_argument.mutex.Unlock();
     // NOTE: errno is shared between this thread and the tracer thread.
-    // internal_waitpid may call syscall() which can access/spoil errno,
+    // internal_waitpid() may call syscall() which can access/spoil errno,
     // so we can't call it now. Instead we for the tracer thread to finish using
-    // the spin loop below. Man page for sched_yield says "In the Linux
+    // the spin loop below. Man page for sched_yield() says "In the Linux
     // implementation, sched_yield() always succeeds", so let's hope it does not
     // spoil errno. Note that this spin loop runs only for brief periods before
     // the tracer thread has suspended us and when it starts unblocking threads.





More information about the llvm-commits mailing list