[PATCH] [PM] Create a separate library for high-level pass management code.
chandlerc at google.com
Thu Mar 5 14:56:16 PST 2015
On Thu, Mar 5, 2015 at 2:51 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> On Mar 5, 2015, at 2:47 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Thu, Mar 5, 2015 at 2:46 PM, Pete Cooper <peter_cooper at apple.com>
>> Yeah, I agree that layering is an issue.
>> The current pass code is in lib/IR, which I think is libCore. There’s no
>> fundamental reason why your code couldn’t also live there right now. Its
>> linked against everything you mentioned already.
> Wait, you've lost me.
> I’m talking about what if you didn’t create a new library. I think you’re
> talking about the relationship between the new libPasses and other
> libraries. Otherwise i’m lost too :)
> I was saying that if you didn’t create a new library, then I assumed the
> new PM code could live in libCore next to the current PM code. And then
> everything just depends on libCore as they currently do.
No no, that's the problem. Everything depends on libCore. Including
libTransforms, libTarget, etc.
the code i've got in Passes right now depends on code in the target library
and in the transforms and analysis library. It can't do that from libCore
without creating a cycle.
So we have:
parsePassPipeline -> SROA (libTransforms) -> PassManager (IR / Core)
If we put parsePassPipeline in Core, we form a cycle.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits