[PATCH] Replace PrintStackTrace(FILE*) with PrintStackTrace(raw_ostream&)
zturner at google.com
Thu Mar 5 10:57:34 PST 2015
I don't think it matters actually. The place in CIndex that was using this
was in cindex::Logger::~Logger(). It was using the `stderr' FILE*. stderr
is unbuffered for one thing, but anwyay as long as we change the rest of
the function to use llvm::errs() then everything should be fine.
On Thu, Mar 5, 2015 at 10:54 AM Reid Kleckner <rnk at google.com> wrote:
> There is a functional difference between raw_ostream and FILE*.
> raw_fd_ostreams have their own buffering that doesn't mesh well with the
> buffering done with the C stdio implementation. I think CIndex.cpp and all
> that code makes sure to print with C stdio. We should be able to resolve
> this pretty easily by creating a raw_file_ostream adapter class, though.
> EMAIL PREFERENCES
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits