[PATCH] [PM] Create a separate library for high-level pass management code.

Pete Cooper peter_cooper at apple.com
Thu Mar 5 10:21:47 PST 2015


Hi Chandler

Sorry to chime in late on this one.

Recently Chris suggested a new library for ‘ToolsSupport’ which would pull some stuff out of libSupport which isn’t needed by all tools.

Your response http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-November/078624.html to this was 'The reason isn't fundamental, it's just that splitting libraries, especially as LLVM is currently set up, has a cost. Super fine-grained libraries don't really make sense in this environment’

I’d like to understand where you’re going with libPasses as this initial patch definitely fits the category of being fine-grained.  Now if this is going to grow in to a library with (and i’m picking a purely arbitrary number here) say 10 files, then sure it might be worth it.  If its going to be 2 or 3 files then i’d say it too fine grained.

But saying that, I actually would love to see LLVM being *much* more modular than it currently is.  I don’t have a use case where i’d ever not link libPasses, but i’d welcome an effort to split out some other libraries where it makes sense.  I’m not necessarily talking about libToolsSupport here, just a general comment about the size of some libraries, especially the amount of stuff which is piling up in libSupport.

Thanks,
Pete


http://reviews.llvm.org/D8054

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list