[PATCH] Lower invoke statepoints and gc.results tied to them.

Philip Reames listmail at philipreames.com
Wed Mar 4 22:49:57 PST 2015


LGTM once test case comments are addressed.  You can submit once that's done without further review.


REPOSITORY
  rL LLVM

================
Comment at: test/CodeGen/X86/statepoint-invoke.ll:1
@@ +1,2 @@
+; RUN: llc < %s 2>&1 | FileCheck %s
+
----------------
Add a target triple.  

================
Comment at: test/CodeGen/X86/statepoint-invoke.ll:9
@@ +8,3 @@
+entry:
+  ; CHECK-LABEL: Ltmp0:
+  ; CHECK: callq _some_other_call
----------------
My experience has been that using labels like this will be a bit fragile.  You should consider using something easier to match on like a call to dummy function.

(Alternatively, you could use FileCheck variables.)

http://reviews.llvm.org/D7760

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list