[PATCH] Improve CodeGenDAGPattern support with multiple explicit results in an instruction pattern

[Craig Topper]

To be honest I don't know if I know the code well enough to know if that
can fail. Just seemed bad to blindly assume there was only one type there.
There are quite a few such "unhandled" asserts in this file so I just wrote
the same.

On Wed, Mar 4, 2015 at 9:59 PM, hfinkel at anl.gov <hfinkel at anl.gov> wrote:

> LGTM, thanks!
>
>
> ================
> Comment at: utils/TableGen/CodeGenDAGPatterns.cpp:3058
> @@ +3057,3 @@
> +    for (unsigned i = 0; i != NumResults; ++i) {
> +      assert(ResNodes[i]->getNumTypes() == 1 && "FIXME: Unhandled");
> +      ResultPattern->setType(i, ResNodes[i]->getExtType(0));
> ----------------
> Please improve the string in this assert to explain what is not handled.
>
> http://reviews.llvm.org/D8073
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>


-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150304/ed2d6092/attachment.html>