[PATCH] [Windows] Implementing backtracing of self

Zachary Turner zturner at google.com
Wed Mar 4 20:15:46 PST 2015

Comment at: lib/Support/Windows/Signals.inc:388
@@ +387,3 @@
+  STACKFRAME64 StackFrame;
+  jmp_buf Buffer;
rnk wrote:
> Zero StackFrame so we don't give uninitialized memory to the unwinder.
Thanks, I missed that.  That led me to find one more improvement, which is that we can set the value of StackFrame.ReturnAddr to _GetReturnAddress().  I don't know how much it'll help, but it certainly won't hurt, so I'll submit the patch with your suggested improvement as well the one to set StackFrame.AddrReturn.



More information about the llvm-commits mailing list