[PATCH] [PM] Create a separate library for high-level pass management code.

[Hal Finkel]

----- Original Message -----
> From: "Chandler Carruth" <chandlerc at gmail.com>
> To: reviews+D8054+public+4e159570c2fea75a at reviews.llvm.org
> Cc: "Commit Messages and Patches for LLVM" <llvm-commits at cs.uiuc.edu>
> Sent: Wednesday, March 4, 2015 8:14:48 PM
> Subject: Re: [PATCH] [PM] Create a separate library for high-level pass	management code. 
> 
> On Wed, Mar 4, 2015 at 8:01 AM, hfinkel at anl.gov < hfinkel at anl.gov >
> wrote:
> 
> 
> > The class is a "PassBuilder" but this name I'm less happy with. It
> > doesn't build passes in any traditional sense and isn't a
> > Builder-style API at all. The class is a PassRegisterer or
> > PassAdder, but neither of those really make a lot of sense. This
> > class is responsible for constructing passes for registry in an
> > analysis manager or for population of a pass pipeline. If anyone
> > has a better name, I would love to hear it. The other candidate I
> > looked at was PassRegistrar, but that doesn't really fit either.
> > There is no register of all the passes in use, and so I think
> > continuing the "registry" analog outside of the registry of pass
> > *names* and *types* is a mistake. The objects themselves are just
> > objects with the new pass manager.
> 
> 
> A little verbose, but how about something like PassPipelineBuilder?
> It isn't just building pipelines though. It also builds analysis
> passes in order to register them with the analysis manager.

Fair enough, but is that just the analysis pipeline?

 -Hal

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory