[PATCH] Turn off .debug_pubnames/pubtypes for PS4.

[David Blaikie]

On Wed, Mar 4, 2015 at 4:15 PM, Robinson, Paul <
Paul_Robinson at playstation.sony.com> wrote:

> r231322.  Didn't Phab used to put the revision number in its email?
>

Yeah, not sure - maybe only if it submits the patch? (arc patch or
somesuch) rather than if it detects the commit? Don't know.


>
> > -----Original Message-----
> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> > bounces at cs.uiuc.edu] On Behalf Of Paul Robinson
> > Sent: Wednesday, March 04, 2015 4:11 PM
> > To: echristo at gmail.com; aprantl at apple.com; dblaikie at gmail.com
> > Cc: llvm-commits at cs.uiuc.edu
> > Subject: Re: [PATCH] Turn off .debug_pubnames/pubtypes for PS4.
> >
> > REPOSITORY
> >   rL LLVM
> >
> > http://reviews.llvm.org/D8067
> >
> > Files:
> >   llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> >   llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll
> >
> > Index: llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll
> > ===================================================================
> > --- llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll
> > +++ llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll
> > @@ -1,7 +1,9 @@
> >  ; RUN: llc -mtriple=x86_64-pc-linux-gnu -filetype=obj -o %t.o < %s
> >  ; RUN: llvm-dwarfdump -debug-dump=pubnames %t.o | FileCheck --check-
> > prefix=LINUX %s
> >  ; RUN: llc -mtriple=x86_64-apple-darwin12 -filetype=obj -o %t.o < %s
> > -; RUN: llvm-dwarfdump -debug-dump=pubnames %t.o | FileCheck --check-
> > prefix=DARWIN %s
> > +; RUN: llvm-dwarfdump -debug-dump=pubnames %t.o | FileCheck --check-
> > prefix=NOPUB %s
> > +; RUN: llc -mtriple=x86_64-scei-ps4 -filetype=obj -o %t.o < %s
> > +; RUN: llvm-dwarfdump -debug-dump=pubnames %t.o | FileCheck --check-
> > prefix=NOPUB %s
> >  ; ModuleID = 'dwarf-public-names.cpp'
> >  ;
> >  ; Generated from:
> > @@ -35,9 +37,9 @@
> >  ;   int global_namespace_variable = 1;
> >  ; }
> >
> > -; Darwin shouldn't be generating the section by default
> > -; DARWIN: debug_pubnames
> > -; DARWIN: {{^$}}
> > +; Darwin and PS4 shouldn't be generating the section by default
> > +; NOPUB: debug_pubnames
> > +; NOPUB: {{^$}}
> >
> >  ; Skip the output to the header of the pubnames section.
> >  ; LINUX: debug_pubnames
> > Index: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> > ===================================================================
> > --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> > +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> > @@ -212,7 +212,7 @@
> >    CurMI = nullptr;
> >
> >    // Turn on accelerator tables for Darwin by default, pubnames by
> > -  // default for non-Darwin, and handle split dwarf.
> > +  // default for non-Darwin/PS4, and handle split dwarf.
> >    if (DwarfAccelTables == Default)
> >      HasDwarfAccelTables = IsDarwin;
> >    else
> > @@ -224,7 +224,7 @@
> >      HasSplitDwarf = SplitDwarf == Enable;
> >
> >    if (DwarfPubSections == Default)
> > -    HasDwarfPubSections = !IsDarwin;
> > +    HasDwarfPubSections = !IsDarwin && !IsPS4;
> >    else
> >      HasDwarfPubSections = DwarfPubSections == Enable;
> >
> > EMAIL PREFERENCES
> >   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150304/420666f0/attachment.html>