[PATCH] Mangler: Don't prefix MS ABI names with a leading ? character

Reid Kleckner rnk at google.com
Wed Mar 4 14:42:27 PST 2015


================
Comment at: test/CodeGen/X86/mangle-question-mark.ll:23
@@ +22,3 @@
+; MACHO: calll "L?withescape at A@@QBEXXZ$stub"
+; MACHO: calll "L?withquestion at A@@QBEXXZ$stub"
+; MACHO: calll "l?privatequestion at A@@QBEXXZ"
----------------
rafael wrote:
> You need to CHECK the non-stub  too. Probably the easiest is to just check with global variables instead of functions.
> 
I'd rather just check the .indirect_symbol directive.

http://reviews.llvm.org/D7775

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list