[llvm] r231214 - Revert "[ADT] fail-fast iterators for DenseMap"

[Reid Kleckner]

A separate define seems like the best we can do. The downside is that we
can't turn this on by default in a standard +Asserts build, or we've just
moved the ABI incompatibility problem to a different define.

We've also had the EXPENSIVE_CHECKS macro for a while. You could throw it
under there. It should probably be renamed LLVM_EXPENSIVE_CHECKS or
something.

On Wed, Mar 4, 2015 at 2:23 PM, Sanjoy Das <sanjoy at playingwithpointers.com>
wrote:

> What do you think about having a separate
> LLVM_ENABLE_FAIL_FAST_ITERATORS macro?  That will be independent of
> NDEBUG and will be explicitly documented to change ABI compatibility
> of data structures.  This way LLDB can always (or never) build llvm
> with LLVM_ENABLE_FAIL_FAST_ITERATORS and enable / disable the macro
> when building LLDB sources consistently.  Doing this could be easier
> than being consistent with NDEBUG.  This approach adds more complexity
> on the LLVM side though, and I'd rather not do it if LLDB can be made
> to be consistent on when it #defines NDEBUG.
>
> -- Sanjoy
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150304/2b0d129b/attachment.html>