[PATCH] Support standard DWARF TLS opcode; currently, only PS4 uses it.

Robinson, Paul Paul_Robinson at playstation.sony.com
Wed Mar 4 13:02:25 PST 2015



> -----Original Message-----
> From: Eric Christopher [mailto:echristo at gmail.com]
> Sent: Wednesday, March 04, 2015 12:26 PM
> To: Robinson, Paul; dblaikie at gmail.com
> Cc: emaste at freebsd.org; aprantl at apple.com; llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] Support standard DWARF TLS opcode; currently, only
> PS4 uses it.
> 
> Sadly LGTM. One inline comment.
> 
> -eric
> 
> 
> ================
> Comment at: test/DebugInfo/X86/tls.ll:31
> @@ -27,1 +30,3 @@
>  ; SINGLE: .section     .debug_info,
> +; DARWIN: .section     __DWARF,__debug_info,
> +
> ----------------
> Can probably just regexp check for section {{.*}}debug_info and not worry
> about it.

Done. r231286, thanks!
--paulr

> 
> http://reviews.llvm.org/D8018
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> 





More information about the llvm-commits mailing list