[PATCH] [compiler-rt] Spring cleaning of compiler-rt symbolizers

[Sergey Matveev]

On Wed, Mar 4, 2015 at 11:28 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:

>
> On Wed, Mar 4, 2015 at 12:18 PM, Sergey Matveev <earthdok at google.com>
> wrote:
>
>> Just saw this CL.
>>
>> Silently falling back to a different symbolizer is not always acceptable,
>> for performance reasons. In Chromium, given the binary size, we never want
>> to fall back to addr2line if llvm-symbolizer cannot be found. Otherwise
>> this happens:
>> https://code.google.com/p/chromium/issues/detail?id=390552
>>
>> So something like a flag to disable this behavior would be nice.
>>
>
> We already have allow_addr2line flag. It is "false" by default, and is
> only set to true in TSan. I don't know how you could hit it in MSan.
>
Probably via asan_symbolize.py. I was only using this as an example. I
wasn't aware that flag existed.


>
>
>>
>>
>> http://reviews.llvm.org/D7827
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>>
>
>
> --
> Alexey Samsonov
> vonosmas at gmail.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150305/3d3bbd18/attachment.html>