[llvm] r231214 - Revert "[ADT] fail-fast iterators for DenseMap"

[Reid Kleckner]

On Wed, Mar 4, 2015 at 9:43 AM, Zachary Turner <zturner at google.com> wrote:

> How necessary to this change is the ABI incompatibility between the cases
> where NDEBUG is and isn't defined?  Is it possible to make them ABI
> compatible while still keeping the meat of the change intact?
>
> It doesn't really seem like a "nice" thing to do to require that people
> who use LLVM as a library use the same compilation flags as LLVM.
>

Early in the history of LLVM, we allowed NDEBUG to control struct layout
and general ABI. Then Alp Toker came along and decided this was a Bad
Thing. He audited the headers and removed it all. Now it's crept back in.

In conclusion, what isn't tested will break.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150304/8a13c542/attachment.html>