[PATCH] LLD: Core: Fix file ordinals of archive members.

Rui Ueyama ruiu at google.com
Wed Mar 4 10:59:19 PST 2015


On Wed, Mar 4, 2015 at 10:58 AM, Shankar Easwaran <shankare at codeaurora.org>
wrote:

> On 3/4/2015 12:33 PM, Rui Ueyama wrote:
>
>> I believed that you wrote this code and was aware of the thing. But as a
>> refresher, the order of symbol resolution and file resolution are not the
>> same. Only object files are visited in order. Files in an archive file is
>> visited only when it's needed. If archive files are grouped with -( and -),
>> the order to visit files in the archives is not the same as the order in
>> the input file list.
>>
>> Previously we set a new and largest ordinal to a file in an archive file
>> as we visit that. So the files in archive files got ordinals in the
>> resolution order, not in the input file order.
>>
> We need the behavior to set ordinals based on resolution order to match
> GNU.


I don't disagree. I pointed out that the orders you mentioned were not the
same.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150304/cffd0a32/attachment.html>


More information about the llvm-commits mailing list