[PATCH] [mips] [IAS] Add missing constraints and improve testing for the .module directive.

Daniel Sanders daniel.sanders at imgtec.com
Wed Mar 4 05:03:42 PST 2015


LGTM with the CHECK-NOT's added


================
Comment at: test/MC/Mips/module-directive-bad.s:9
@@ +8,3 @@
+    .llvm_internal_mips_reallow_module_directive
+    .module fp=32
+
----------------
You ought to have a CHECK-NOT on each of these to ensure the error doesn't trigger.

http://reviews.llvm.org/D7140

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list