[PATCH] Add a flag to experiment with outlining optional branches.

Daniel Jasper djasper at google.com
Tue Mar 3 23:19:09 PST 2015


Yes. The reasoning is that in this case the entire branch (containing A, B
and C) will already be outlined and we don't want to fragment this further.
In initial benchmarks, this seemed to have a slight benefit over
additionally outlining B. Lots of stuff we can investigate, though.

On Wed, Mar 4, 2015 at 8:03 AM, Xinliang David Li <xinliangli at gmail.com>
wrote:

> If I read the change correctly,  'B' block in the following case can not
> be outlined. Is it intended?
>
> David
>
> if (cond1) {
>     A
>     if (cond2) {
>
>          B
>      }
>     C
>     ...
> }
> else {
>    D
> }
>
> On Tue, Mar 3, 2015 at 10:46 PM, Daniel Jasper <djasper at google.com> wrote:
>
>> Re-add the test.
>>
>>
>> http://reviews.llvm.org/D7719
>>
>> Files:
>>   lib/CodeGen/MachineBlockPlacement.cpp
>>   test/CodeGen/X86/code_placement_outline_optional_branches.ll
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150304/a96c69c5/attachment.html>


More information about the llvm-commits mailing list