[llvm] r231201 - Use report_fatal_error instead of unreachable for -fast-isel-abort

Mehdi Amini mehdi.amini at apple.com
Tue Mar 3 17:48:39 PST 2015


Author: mehdi_amini
Date: Tue Mar  3 19:48:39 2015
New Revision: 231201

URL: http://llvm.org/viewvc/llvm-project?rev=231201&view=rev
Log:
Use report_fatal_error instead of unreachable for -fast-isel-abort

Suggestion by Andrea Di Biagio

From: Mehdi Amini <mehdi.amini at apple.com>

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp?rev=231201&r1=231200&r2=231201&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp Tue Mar  3 19:48:39 2015
@@ -1182,7 +1182,7 @@ void SelectionDAGISel::SelectAllBasicBlo
           // Fast isel failed to lower these arguments
           ++NumFastIselFailLowerArguments;
           if (EnableFastISelAbort > 1)
-            llvm_unreachable("FastISel didn't lower all arguments");
+            report_fatal_error("FastISel didn't lower all arguments");
 
           // Use SelectionDAG argument lowering
           LowerArguments(Fn);
@@ -1254,7 +1254,7 @@ void SelectionDAGISel::SelectAllBasicBlo
           if (EnableFastISelAbort > 2)
             // FastISel selector couldn't handle something and bailed.
             // For the purpose of debugging, just abort.
-            llvm_unreachable("FastISel didn't select the entire block");
+            report_fatal_error("FastISel didn't select the entire block");
 
           if (!Inst->getType()->isVoidTy() && !Inst->use_empty()) {
             unsigned &R = FuncInfo->ValueMap[Inst];
@@ -1297,7 +1297,7 @@ void SelectionDAGISel::SelectAllBasicBlo
         if (ShouldAbort)
           // FastISel selector couldn't handle something and bailed.
           // For the purpose of debugging, just abort.
-          llvm_unreachable("FastISel didn't select the entire block");
+          report_fatal_error("FastISel didn't select the entire block");
 
         NumFastIselFailures += NumFastIselRemaining;
         break;





More information about the llvm-commits mailing list