[PATCH] [Inliner] Use whitelist instead of blacklist when checking function attribute compatibility and make the check stricter

[Chandler Carruth]

I really don't like this. I really don't like the prior solution either.

Today, we have subtle, hard to diagnose correctness bugs. Bad bad bad.

With this we have subtle, hard to diagnose performance bugs combined with a bit of a maintenance nightmare to keep this up to date. Bad bad bad.

I also fear the performance bugs will in practice happen much more often. I'm seriously worried about the string attributes for example.

I think we need to back up and think of a better design for this. A *much* better design. Do you have any thoughts on how to do this in a more maintainable way? If not I'll try to write something else.

Naturally, if there are specific attributes that are casuing problems, let's get a targeted fix in place for those attributes.


http://reviews.llvm.org/D7802

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/