[PATCH] [compiler-rt] Symbolizer refactoring: Unify access to symbolizer tools from POSIXSymbolizer

Alexey Samsonov vonosmas at gmail.com
Tue Mar 3 15:30:48 PST 2015

On Tue, Mar 3, 2015 at 3:26 PM, Kuba Brecka <kuba.brecka at gmail.com> wrote:

> Landed in r231162.
> > LGTM. Do you plan to inherit WinSymbolizer from SymbolizerTool?
> Yes, although it's not as straight-forward as I'd like. I planned to move
> the implementation of `POSIXSymbolizer` into just `Symbolizer`, which would
> no longer have any subclasses. The `ChooseSymbolizer` would then simply
> have a `if (SANITIZER_WINDOWS)` branch in it, and we wouldn't need
> `PlatformInit` at all.

Right, I also think we should do that, if possible (maybe, re-implement
ChooseSymbolizer() on Windows to avoid having #ifdefs) and get rid of
PlatformInit. In that case Symbolizer constructor would just initialize
symbolozer_tool_ with the result of platform-specific ChooseSymbolizer().

> Speaking of Windows, I found out that we currently don't run the testcases
> from the main `TestCases/` directory on Windows (we treat them as if they
> were in `TestCases/Posix/`), is that intentional?  If yes, what's the point
> of having a separate `Posix` subdirectory?

That's right. I believe we would eventually run all TestCases/ under
Windows as well, but for now we're just not ready for the switch.

> http://reviews.llvm.org/D8029
>   http://reviews.llvm.org/settings/panel/emailpreferences/

Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150303/b3c0d4b9/attachment.html>

More information about the llvm-commits mailing list