[patch] Check for isDiagnosticEnabled even if we have a dig handler
rafael.espindola at gmail.com
Tue Mar 3 15:28:44 PST 2015
> RespectDiagnosticFilters does look like more flexibility than
> necessary, but that is independent. I will try writing a patch to see
> what breaks.
And yes, it breaks clang. The issue is that clang expects to be passed
all the remarks and to do its own filtering for -Rpass.
Diego, do you remember why it was implemented like that? The filtering
looks duplicated with the one in LLVM. Couldn't clang just pass the
pattern down to LLVM?
For reference, the patch I had in mind is attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4075 bytes
Desc: not available
More information about the llvm-commits