[PATCH] Move emitDIE and emitAbbrev to AsmPrinter. NFC.

[Frédéric Riss]

> On Mar 3, 2015, at 2:58 PM, Eric Christopher <echristo at gmail.com> wrote:
> 
> 
> 
> On Tue, Mar 3, 2015 at 2:43 PM Frédéric Riss <friss at apple.com <mailto:friss at apple.com>> wrote:
> 
> > On Mar 3, 2015, at 11:57 AM, Eric Christopher <echristo at gmail.com <mailto:echristo at gmail.com>> wrote:
> >
> > Looks good in theory.
> 
> Is that a LGTM, or do you wan me to respin the patch to you?
> 
> 
> It's fine for me, I just didn't want to explicitly LGTM a patch that doesn't build ;)

I knew I shouldn’t have said that!

> Feel free to commit when you'd like.

Thanks.

Fred

> -eric
>  
> > I'd probably rename the emitDIE and emitAbbrevs to be emitDwarfDIE etc as part of the migration.
> 
> Sure.
> 
> Fred
> 
> > -eric
> >
> >
> > http://reviews.llvm.org/D8024 <http://reviews.llvm.org/D8024>
> >
> > EMAIL PREFERENCES
> >  http://reviews.llvm.org/settings/panel/emailpreferences/ <http://reviews.llvm.org/settings/panel/emailpreferences/>
> >
> >
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150303/d189f5d3/attachment.html>