[PATCH] [compiler-rt] Symbolizer refactoring: Unify access to symbolizer tools from POSIXSymbolizer

Alexey Samsonov vonosmas at gmail.com
Tue Mar 3 15:00:17 PST 2015


LGTM. Do you plan to inherit WinSymbolizer from SymbolizerTool?


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:490
@@ +489,3 @@
+  if (path_to_external && path_to_external[0] == '\0') {
+    return nullptr;
+  }
----------------
Restore the comment here (external symbolizer is explicitly disabled).

http://reviews.llvm.org/D8029

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list