[llvm] r230882 - DebugInfo: Convert DW_OP_piece => DW_OP_bit_piece

Adrian Prantl aprantl at apple.com
Tue Mar 3 14:07:58 PST 2015


Thanks!

-- adrian
> On Feb 28, 2015, at 3:57 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> Author: dexonsmith
> Date: Sat Feb 28 17:57:16 2015
> New Revision: 230882
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=230882&view=rev
> Log:
> DebugInfo: Convert DW_OP_piece => DW_OP_bit_piece
> 
> r228631 stopped using `DW_OP_piece` inside `DIExpression`s in the IR,
> but it apparently missed updating these testcases.  Caught by verifier
> checks for `MDExpression` while working on moving the new hierarchy into
> place.
> 
> Modified:
>    llvm/trunk/test/DebugInfo/piece-verifier.ll
>    llvm/trunk/test/Transforms/Inline/alloca-dbgdeclare.ll
> 
> Modified: llvm/trunk/test/DebugInfo/piece-verifier.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/piece-verifier.ll?rev=230882&r1=230881&r2=230882&view=diff
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/piece-verifier.ll (original)
> +++ llvm/trunk/test/DebugInfo/piece-verifier.ll Sat Feb 28 17:57:16 2015
> @@ -47,8 +47,8 @@ attributes #1 = { nounwind readnone }
> !21 = !MDLocation(line: 3, scope: !4)
> !22 = !{!"0x101\00s\0016777219\000", !4, !5, !9} ; [ DW_TAG_arg_variable ] [s] [line 3]
> !23 = !MDLocation(line: 4, scope: !4)
> -!24 = !{!"0x102\006\00147\000\008"} ; [ DW_TAG_expression ] [DW_OP_piece 0 8] [piece, size 8, offset 0]
> +!24 = !{!"0x102\006\00157\000\0064"} ; [ DW_TAG_expression ] [DW_OP_bit_piece 0 64] [piece, size 64, offset 0]
> !25 = !{}
> -; This expression has elements after DW_OP_piece.
> +; This expression has elements after DW_OP_bit_piece.
> ; CHECK: DIExpression does not Verify
> -!27 = !{!"0x102\00147\008\004\006"} ; [ DW_TAG_expression ] [DW_OP_piece 8 4] [piece, size 4, offset 8]
> +!27 = !{!"0x102\00157\0064\0032\006"} ; [ DW_TAG_expression ] [DW_OP_bit_piece 64 32] [piece, size 32, offset 64]
> 
> Modified: llvm/trunk/test/Transforms/Inline/alloca-dbgdeclare.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Inline/alloca-dbgdeclare.ll?rev=230882&r1=230881&r2=230882&view=diff
> ==============================================================================
> --- llvm/trunk/test/Transforms/Inline/alloca-dbgdeclare.ll (original)
> +++ llvm/trunk/test/Transforms/Inline/alloca-dbgdeclare.ll Sat Feb 28 17:57:16 2015
> @@ -130,10 +130,10 @@ attributes #3 = { noreturn nounwind }
> !45 = !MDLocation(line: 9, scope: !15)
> !46 = !{!"0x101\00p1\0016777222\000", !15, !16, !"_ZTS1A", !47} ; [ DW_TAG_arg_variable ] [p1] [line 6]
> !47 = distinct !MDLocation(line: 11, scope: !21)
> -!48 = !{!"0x102\00147\004\0020"}                  ; [ DW_TAG_expression ] [DW_OP_piece offset=4, size=20]
> +!48 = !{!"0x102\00157\0032\00160"}                  ; [ DW_TAG_expression ] [DW_OP_bit_piece offset=32, size=160]
> !49 = !MDLocation(line: 6, scope: !15, inlinedAt: !47)
> !50 = !MDLocation(line: 11, scope: !21)
> -!51 = !{!"0x102\00147\000\004"}                   ; [ DW_TAG_expression ] [DW_OP_piece offset=0, size=4]
> +!51 = !{!"0x102\00157\000\0032"}                   ; [ DW_TAG_expression ] [DW_OP_bit_piece offset=0, size=32]
> !52 = !MDLocation(line: 7, scope: !34, inlinedAt: !47)
> !53 = !MDLocation(line: 7, scope: !15, inlinedAt: !47)
> !54 = !MDLocation(line: 8, scope: !34, inlinedAt: !47)
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list