[PATCH] Anonymous namespaces are missing import DW_TAG_imported_module.
aprantl at apple.com
Tue Mar 3 12:58:14 PST 2015
> On Feb 27, 2015, at 1:53 PM, Katya Romanova <Katya_Romanova at playstation.sony.com> wrote:
> Hi David,
> Yes, these are exactly 4 differences that I wanted to point out.
> The questionable differences are #1 and #3.
> - GCC doesn't put line/file on a namespace, Clang does. Clang should omit them for brevity
> Should I remove generation of line/file names for anonymous namespaces before I commit my change?
[Sorry for replying so late to this thread.]
Removing the line/file names would be great, because it would solve the LTO bug described in
but we need to be careful to not accidentally unique anonymous namespaces as outlined later in that thread.
> --GCC adds line/file on imported_module, Clang doesn't. Clang could add these, I'm not sure if any debugger cares - notionally they could do more accurate expression evaluation with that information (not using the using directive when the user is evaluating an expression in a context lexically prior to the using directive).
> Our debugger doesn't care. I'm not sure if other debuggers care. So, I won't do any changes with respect of this.
> Is my latest patch look OK or should I change anything?
> EMAIL PREFERENCES
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
More information about the llvm-commits