[PATCH] Remove getDataLayout() from Instruction/GlobalValue/BasicBlock/Function
mehdi.amini at apple.com
Tue Mar 3 12:50:41 PST 2015
Note there is already a comment in the Doxygen.
This one for the BasicBlock:
/// Note: this is undefined behavior if the block does not have a parent.
And this one for the instruction:
/// Note: this is undefined behavior if the instruction does not have a
/// parent, or the parent basic block does not have a parent function.
> On Mar 3, 2015, at 12:44 PM, Eric Christopher <echristo at gmail.com> wrote:
> LGTM with perhaps a comment of "this can crash if parent is null, don't call this without a parent" or something. Up to you on the comment :)
> EMAIL PREFERENCES
More information about the llvm-commits